Leverage LSP to do compile instead of CLI #7239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunyu3
requested review from
RodgeFu,
bterlson,
markcowl,
allenjzhang,
timotheeguerin,
chrisradek,
AlitzelMendez,
lirenhe and
witemple-msft
as code owners
|
You can try these changes here
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
RodgeFu
reviewed
May 14, 2025
RodgeFu
reviewed
May 14, 2025
RodgeFu
reviewed
May 14, 2025
RodgeFu
reviewed
May 14, 2025
RodgeFu
reviewed
May 14, 2025
RodgeFu
reviewed
May 14, 2025
RodgeFu
reviewed
May 14, 2025
lirenhe
approved these changes
May 15, 2025
lirenhe
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6663
Now we are having many problems when triggering the compile from CLI and handling its output in our Output window like multiple loglevel, how to handle ```stderr``, coloring and so on.
So to resolve all these problems, let's trigger compile through LSP instead of CLI so that we can retrieve the result of compile directly which is more reliable and also easier to do post-processing.